-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flattened process fields in default ingest pipeline #4709
fix flattened process fields in default ingest pipeline #4709
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
packages/crowdstrike/data_stream/falcon/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the pull request to use the suggested code.
packages/crowdstrike/data_stream/falcon/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to have the test expectations updated. The diff for this is
diff --git a/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-events.log-expected.json b/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-events.log-expected.json
index 2e0dfc996..bef0cf123 100644
--- a/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-events.log-expected.json
+++ b/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-events.log-expected.json
@@ -85,14 +85,14 @@
},
"message": "Terminated a process related to the deletion of backups, which is often indicative of ransomware activity.",
"process": {
+ "args": [
+ "C:\\Windows\\Explorer.EXE"
+ ],
+ "command_line": "C:\\Windows\\Explorer.EXE",
+ "executable": "C:\\Windows\\Explorer.EXE",
"name": "explorer.exe",
"pid": 38684386611
},
- "process.args": [
- "C:\\Windows\\Explorer.EXE"
- ],
- "process.command_line": "C:\\Windows\\Explorer.EXE",
- "process.executable": "C:\\Windows\\Explorer.EXE",
"related": {
"hash": [
"6a671b92a69755de6fd063fcbe4ba926d83b49f78c42dbaeed8cdb6bbc57576a",
diff --git a/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-sample.log-expected.json b/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-sample.log-expected.json
index 918cae671..df0299c3d 100644
--- a/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-sample.log-expected.json
+++ b/packages/crowdstrike/data_stream/falcon/_dev/test/pipeline/test-falcon-sample.log-expected.json
@@ -512,6 +512,11 @@
},
"message": "This file meets the machine learning-based on-sensor AV protection's low confidence threshold for malicious files.",
"process": {
+ "args": [
+ "\"C:\\ProgramData\\file\\path\\filename.exe\""
+ ],
+ "command_line": "\"C:\\ProgramData\\file\\path\\filename.exe\"",
+ "executable": "\"C:\\ProgramData\\file\\path\\filename.exe\"",
"name": "filename.exe",
"parent": {
"command_line": "C:\\Windows\\Explorer.EXE",
@@ -519,11 +524,6 @@
},
"pid": 663790158277
},
- "process.args": [
- "\"C:\\ProgramData\\file\\path\\filename.exe\""
- ],
- "process.command_line": "\"C:\\ProgramData\\file\\path\\filename.exe\"",
- "process.executable": "\"C:\\ProgramData\\file\\path\\filename.exe\"",
"related": {
"hash": [
packages/crowdstrike/data_stream/falcon/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
/test |
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Package crowdstrike - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=crowdstrike |
What does this PR do?
Fix the parse of flattened
process
fields in the default Falcon ingest pipeline.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots