Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCS input to Cloudflare Logpush #4720

Merged
merged 10 commits into from
Dec 1, 2022

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Adds support for GCS input to the Cloudflare Logpush package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2022-11-28 at 1 09 39 PM

@ShourieG ShourieG requested a review from a team as a code owner November 28, 2022 07:40
@elasticmachine
Copy link

elasticmachine commented Nov 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T09:34:56.588+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ShourieG ShourieG requested a review from efd6 November 28, 2022 08:03
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (89/89) 💚
Lines 94.37% (2380/2522) 👎 -1.902
Conditionals 100.0% (0/0) 💚

@ShourieG ShourieG requested a review from P1llus November 28, 2022 08:20
@ShourieG ShourieG self-assigned this Nov 29, 2022
@ShourieG
Copy link
Contributor Author

@efd6 have updated the PR

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor change.

packages/cloudflare_logpush/manifest.yml Outdated Show resolved Hide resolved
packages/cloudflare_logpush/manifest.yml Outdated Show resolved Hide resolved
packages/cloudflare_logpush/manifest.yml Outdated Show resolved Hide resolved
packages/cloudflare_logpush/manifest.yml Outdated Show resolved Hide resolved
@ShourieG ShourieG merged commit 941348f into elastic:main Dec 1, 2022
@jamiehynds
Copy link

Thanks @ShourieG - a few users waiting on this one and very excited to start testing out GCS with Logpush.

@elasticmachine
Copy link

Package cloudflare_logpush - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants