Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] Introducing cspm #4752

Merged
merged 4 commits into from
Dec 4, 2022
Merged

[Cloud Posture] Introducing cspm #4752

merged 4 commits into from
Dec 4, 2022

Conversation

kfirpeled
Copy link
Contributor

@kfirpeled kfirpeled commented Dec 1, 2022 •
edited
Loading

What does this PR do?

In the following PR we are introducing CSPM policy template with AWS

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

For fully testing it, you should test with the following kibana changes: elastic/kibana#146842

Related issues

Screenshots

Screen Shot 2022-12-04 at 15 06 22

@kfirpeled kfirpeled linked an issue Dec 1, 2022 that may be closed by this pull request
[Cloud Posture] CSPM integration - Create new CSPM integration policy template elastic/kibana#146523
Closed
@elasticmachine
Copy link

elasticmachine commented Dec 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-04T13:02:51.233+0000

  • Duration: 13 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 2, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.273
Classes 100.0% (0/0) 💚 2.273
Methods 25.0% (1/4) 👎 -63.416
Lines 100.0% (0/0) 💚 6.553
Conditionals 100.0% (0/0) 💚

@kfirpeled kfirpeled added enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Dec 4, 2022
@kfirpeled kfirpeled marked this pull request as ready for review December 4, 2022 13:11
@kfirpeled kfirpeled requested a review from a team as a code owner December 4, 2022 13:11
oren-zohar
oren-zohar approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfirpeled kfirpeled merged commit 00285f9 into elastic:main Dec 4, 2022
@kfirpeled kfirpeled deleted the cspm/added_cis_aws branch December 4, 2022 13:39
@kfirpeled kfirpeled mentioned this pull request Dec 4, 2022
Merged
@elasticmachine
Copy link

Package cloud_security_posture - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

kfirpeled added a commit to elastic/kibana that referenced this pull request Dec 5, 2022
@kfirpeled
[Cloud Posture] Remove k8s instructions for cspm policies (#146843)
f72e50f 
## Summary

When installing CSPM the kubernetes deployment is not relevant and
shouldn't be visible.
This PR is fixing that

<img width="837" alt="Screen Shot 2022-12-04 at 15 41 00"
src="https://user-images.githubusercontent.com/61654899/205493957-7d8e95c3-8e20-4e34-9c3d-556e201e62f9.png">

## How to test it
In order to install CSPM integration you use cloud_security_posture
1.1.0 which is recently available
elastic/integrations#4752
CohenIdo added a commit to CohenIdo/integrations that referenced this pull request Dec 12, 2022
@CohenIdo
Revert "[Cloud Posture] Introducing cspm (elastic#4752)"
f4902a6 
This reverts commit 00285f9.
@olegsu olegsu mentioned this pull request Dec 18, 2022
Merged
2 tasks
@CohenIdo CohenIdo mentioned this pull request Dec 22, 2022
Merged
@orouz orouz mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Posture] CSPM integration - Create new CSPM integration policy template
3 participants
@kfirpeled @elasticmachine @oren-zohar