Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Kubernetes] Nodes: Fix memory usage by node #4756

Merged
merged 5 commits into from
Dec 2, 2022
Merged

[Metrics Kubernetes] Nodes: Fix memory usage by node #4756

merged 5 commits into from
Dec 2, 2022

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Dec 2, 2022

What does this PR do?

Fix the function to calculate pod memory usage.

Screenshots

Since, the total memory node used in the function was kubernetes.node.memory.allocatable.bytes, every memory used by system daemons was not being considered. Changing it to kubernetes.node.memory.capacity.bytes fix problems like the one mentioned in #4577.

Before:
image

After:
image

@constanca-m constanca-m added bug Something isn't working, use only for issues dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Dec 2, 2022
@constanca-m constanca-m requested review from a team as code owners December 2, 2022 14:00
@elasticmachine
Copy link

elasticmachine commented Dec 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T14:09:17.526+0000

  • Duration: 29 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78) 👎 -3.7
Lines 100.0% (0/0) 💚 6.171
Conditionals 100.0% (0/0) 💚

@tetianakravchenko
Copy link
Contributor

could you please add a screenshot to the PR description that includes the changes in this PR, instead of the on with the issue?

@constanca-m constanca-m merged commit f52e6db into elastic:main Dec 2, 2022
@constanca-m constanca-m removed the bug Something isn't working, use only for issues label Dec 2, 2022
@elasticmachine
Copy link

Package kubernetes - 1.29.2 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@constanca-m constanca-m self-assigned this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants