-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics Kubernetes] Nodes: Fix memory usage by node #4756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
added
bug
Something isn't working, use only for issues
dashboard
Relates to a Kibana dashboard bug, enhancement, or modification.
Team:Cloudnative-Monitoring
Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
labels
Dec 2, 2022
🌐 Coverage report
|
could you please add a screenshot to the PR description that includes the changes in this PR, instead of the on with the issue? |
tetianakravchenko
approved these changes
Dec 2, 2022
Package kubernetes - 1.29.2 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dashboard
Relates to a Kibana dashboard bug, enhancement, or modification.
Team:Cloudnative-Monitoring
Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the function to calculate pod memory usage.
Screenshots
Since, the total memory node used in the function was
kubernetes.node.memory.allocatable.bytes
, every memory used by system daemons was not being considered. Changing it tokubernetes.node.memory.capacity.bytes
fix problems like the one mentioned in #4577.Before:
After: