Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Storage Account - Replace link to indonesian docs #4774

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

ckauf
Copy link
Contributor

@ckauf ckauf commented Dec 7, 2022

What does this PR do?

Change link from indonesian Azure documentation to englisch

Change link from indonesian Azure documentation to englisch
@ckauf ckauf added the documentation Improvements or additions to documentation label Dec 7, 2022
@ckauf ckauf requested a review from a team as a code owner December 7, 2022 09:59
@elasticmachine
Copy link

elasticmachine commented Dec 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-12T09:58:34.964+0000

  • Duration: 13 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@zmoog
Copy link
Contributor

zmoog commented Dec 12, 2022

Hey @ckauf, thank you for creating a PR to update the link to point to docs in English!

@zmoog
Copy link
Contributor

zmoog commented Dec 12, 2022

I found a few other occurrences of links to non-English docs. I'll update them and build a new release of the integration.

The source docs are at `_dev/build/docs`. After updating the sources,
we nee to run the following commands:

    $ cd packages/azure_metrics
    $ elastic-package build

To update the generated docs at `docs`.
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👍 6.667
Lines 100.0% (21/21) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@zmoog zmoog merged commit 72d7663 into main Dec 13, 2022
@zmoog zmoog deleted the ckauf-storage-account branch December 13, 2022 09:10
@elasticmachine
Copy link

Package azure_metrics - 1.0.13 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants