Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] - remove state from csp-rule templates #4878

Merged
merged 9 commits into from
Jan 10, 2023
Merged

[Cloud Posture] - remove state from csp-rule templates #4878

merged 9 commits into from
Jan 10, 2023

Conversation

ofiriro3
Copy link
Contributor

What does this PR do?

This PR removes the state from the csp-rule-templates

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ofiriro3 ofiriro3 added deprecation breaking change 8.7 candidate Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Dec 21, 2022
@ofiriro3 ofiriro3 linked an issue Dec 21, 2022 that may be closed by this pull request
[Cloud Posture] Remove state from csp_rule_template elastic/kibana#143524
Closed
14 tasks
@elasticmachine
Copy link

elasticmachine commented Dec 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-10T08:50:39.950+0000

  • Duration: 14 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 21, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.921
Classes 100.0% (0/0) 💚 2.921
Methods 25.0% (1/4) 👎 -65.362
Lines 100.0% (0/0) 💚 9.063
Conditionals 100.0% (0/0) 💚

kfirpeled
kfirpeled reviewed Dec 25, 2022
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
@@ -1,4 +1,24 @@
# newer versions go on top
- version: "1.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear version bump.
can it be 1.1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go over it yet, it is still in draft.

But anyway, it's an important comment.

For sure it is not 1.2.2, I am not sure if we want it to be 1.1.3, since this change is a breaking change.
We deprecate two of the rules template fields.
Usually, when deprecating fields you bump either the major or the minor depending on the change and the impact on customers.

So what do you suggest in this case?

I think that 1.2.0 should be Ok since it is a deprecation, but it doesn't impact customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.3 - was decided.

@ofiriro3 ofiriro3 changed the base branch from main to 1password_itemusage_action January 2, 2023 16:50
@ofiriro3 ofiriro3 changed the base branch from 1password_itemusage_action to main January 2, 2023 16:50
@ofiriro3 ofiriro3 marked this pull request as ready for review January 2, 2023 17:46
@ofiriro3 ofiriro3 requested a review from a team as a code owner January 2, 2023 17:46
@ofiriro3
Copy link
Contributor Author

ofiriro3 commented Jan 3, 2023

Was verified with Kibana

@ofiriro3
Copy link
Contributor Author

ofiriro3 commented Jan 4, 2023

/test

kfirpeled
kfirpeled approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofiriro3 ofiriro3 merged commit 2c8a1d5 into elastic:main Jan 10, 2023
@ofiriro3 ofiriro3 deleted the remove_state_from_csp_rule_template branch January 10, 2023 09:18
@ofiriro3 ofiriro3 changed the title [Cloud security posture] - remove state from csp-rule templates [Cloud Posture] - remove state from csp-rule templates Jan 10, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.2.4 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
8.7 candidate breaking change deprecation Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Posture] Remove state from csp_rule_template
3 participants
@ofiriro3 @elasticmachine @kfirpeled