Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_meraki] Improved timezone offset error handling #4907

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Dec 29, 2022

Type of change

  • Enhancement

What does this PR do?

Helps improve error handling of timezone field w.r.t the presence of the original time field _temp.ts_nano in the ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner December 29, 2022 11:22
@ShourieG ShourieG self-assigned this Dec 29, 2022
@elasticmachine
Copy link

elasticmachine commented Dec 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-09T05:58:33.829+0000

  • Duration: 19 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.686
Classes 100.0% (9/9) 💚 2.686
Methods 100.0% (62/62) 💚 8.805
Lines 97.995% (1075/1097) 👍 6.534
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change. Rest LGTM

@ShourieG ShourieG merged commit 2b6462a into elastic:main Jan 9, 2023
@ShourieG ShourieG deleted the bugfix/cisco_meraki branch January 9, 2023 06:23
@elasticmachine
Copy link

Package cisco_meraki - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants