[Cloud Posture] rule_number mapping update #5054

oren-zohar · 2023-01-19T09:43:17Z

What does this PR do?

update the rule_number mapping
update rules templates

Related issues

Related: Move rule.rule_number to rule.benchmark.rule_number cloudbeat#644

elasticmachine · 2023-01-19T09:56:46Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-02-12T15:22:18.546+0000
Duration: 14 min 26 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2
Skipped	0
Total	2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-01-19T09:56:56Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 3.421
Classes	100.0% (`0/0`)	💚 3.421
Methods	25.0% (`1/4`)	👎 -66.071
Lines	100.0% (`0/0`)	💚 8.626
Conditionals	100.0% (`0/0`)	💚

…field # Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/manifest.yml

oren-zohar · 2023-01-29T16:30:25Z

/test

oren-zohar · 2023-01-31T21:36:41Z

/test

orouz · 2023-02-02T11:50:21Z

/test

kfirpeled

LGTM, please fix conflicts (maintain the prereleased version 1.2.10-next)

…field # Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/data_stream/findings/fields/rule.yml # packages/cloud_security_posture/manifest.yml

oren-zohar · 2023-02-12T08:25:58Z

Related to this:

Fix id uniqueness csp-security-policies#193

ari-aviran

Please review the comments before merging

packages/cloud_security_posture/changelog.yml

ari-aviran · 2023-02-12T08:40:34Z

...es/cloud_security_posture/kibana/csp_rule_template/04e01d1a-d7d4-5020-a398-8aadd3fe32ae.json

@@ -1,18 +1,18 @@
 {
-    "id": "1d3a468f-78ca-54ff-a43c-0d205ad832b7",
+    "id": "04e01d1a-d7d4-5020-a398-8aadd3fe32ae",


Please test an upgrade from an earlier version of the integration to this version to ensure saved objects are deleted and re-installed properly since the IDs changed

ari-aviran · 2023-02-12T08:42:53Z

...es/cloud_security_posture/kibana/csp_rule_template/04e01d1a-d7d4-5020-a398-8aadd3fe32ae.json

@@ -33,4 +35,4 @@
        "csp-rule-template": "8.7.0"
    },
    "coreMigrationVersion": "8.7.0"
-}
+}


All of these are missing a line break at the end of the file, consider modifying the script and regenerating all the rules

ari-aviran · 2023-02-12T08:44:20Z

@oren-zohar this also resolves elastic/csp-security-policies#142 right?

oren-zohar · 2023-02-12T09:23:00Z

@oren-zohar this also resolves elastic/csp-security-policies#142 right?

yes :)

elasticmachine · 2023-02-13T16:19:15Z

Package cloud_security_posture - 1.2.10-beta1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

oren-zohar added 2 commits January 19, 2023 11:43

[Cloud Posture] CSP rule_number mapping update

6e6cb58

update PR link

ee2dbcd

oren-zohar changed the title ~~[Cloud Posture] CSP rule_number mapping update~~ [Cloud Posture] rule_number mapping update Jan 19, 2023

update rules templates

9f78015

oren-zohar added Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] Integration:cloud_security_posture Security Posture Management labels Jan 19, 2023

oren-zohar requested a review from ari-aviran January 19, 2023 13:53

oren-zohar marked this pull request as ready for review January 19, 2023 13:53

oren-zohar requested a review from a team as a code owner January 19, 2023 13:53

oren-zohar mentioned this pull request Jan 19, 2023

Move rule.rule_number to rule.benchmark.rule_number elastic/cloudbeat#644

Closed

5 tasks

split release

864981d

kfirpeled mentioned this pull request Jan 29, 2023

Hide csp-rule-template from SO management screen elastic/kibana#149793

Open

2 tasks

Merge remote-tracking branch 'upstream/main' into moving-rule_number-…

b0ade4b

…field # Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/manifest.yml

orouz mentioned this pull request Jan 29, 2023

[Cloud Posture] add posture_type field to rule saved object elastic/kibana#149796

Merged

oren-zohar and others added 2 commits February 2, 2023 17:14

Merge branch 'main' into moving-rule_number-field

6550152

update manifest.yml

eb15c16

kfirpeled reviewed Feb 9, 2023

View reviewed changes

oren-zohar added 2 commits February 12, 2023 00:47

fix id uniqueness

43fad00

Merge remote-tracking branch 'upstream/main' into moving-rule_number-…

014db31

…field # Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/data_stream/findings/fields/rule.yml # packages/cloud_security_posture/manifest.yml

ari-aviran approved these changes Feb 12, 2023

View reviewed changes

oren-zohar added 2 commits February 12, 2023 13:33

update version

18bb259

update version

c98384e

update version

e44a066

oren-zohar merged commit aaeea77 into elastic:main Feb 12, 2023

oren-zohar deleted the moving-rule_number-field branch February 12, 2023 15:39

oren-zohar mentioned this pull request Feb 12, 2023

Create CIS AWS rules templates elastic/csp-security-policies#142

Closed

4 tasks

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023

[Cloud Posture] rule_number mapping update (elastic#5054)

5ae1b11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cloud Posture] rule_number mapping update #5054

[Cloud Posture] rule_number mapping update #5054

oren-zohar commented Jan 19, 2023 •

edited

Loading

elasticmachine commented Jan 19, 2023 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Jan 19, 2023 •

edited

Loading

oren-zohar commented Jan 29, 2023

oren-zohar commented Jan 31, 2023

orouz commented Feb 2, 2023

kfirpeled left a comment •

edited

Loading

oren-zohar commented Feb 12, 2023

ari-aviran left a comment

ari-aviran Feb 12, 2023

ari-aviran Feb 12, 2023

ari-aviran commented Feb 12, 2023

oren-zohar commented Feb 12, 2023

elasticmachine commented Feb 13, 2023

[Cloud Posture] rule_number mapping update #5054

[Cloud Posture] rule_number mapping update #5054

Conversation

oren-zohar commented Jan 19, 2023 • edited Loading

What does this PR do?

Related issues

elasticmachine commented Jan 19, 2023 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Jan 19, 2023 • edited Loading

🌐 Coverage report

oren-zohar commented Jan 29, 2023

oren-zohar commented Jan 31, 2023

orouz commented Feb 2, 2023

kfirpeled left a comment • edited Loading

Choose a reason for hiding this comment

oren-zohar commented Feb 12, 2023

ari-aviran left a comment

Choose a reason for hiding this comment

ari-aviran Feb 12, 2023

Choose a reason for hiding this comment

ari-aviran Feb 12, 2023

Choose a reason for hiding this comment

ari-aviran commented Feb 12, 2023

oren-zohar commented Feb 12, 2023

elasticmachine commented Feb 13, 2023

oren-zohar commented Jan 19, 2023 •

edited

Loading

elasticmachine commented Jan 19, 2023 •

edited

Loading

elasticmachine commented Jan 19, 2023 •

edited

Loading

kfirpeled left a comment •

edited

Loading