Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o365_audit] Add NewValue field #5115

Merged
merged 7 commits into from
Feb 2, 2023
Merged

[o365_audit] Add NewValue field #5115

merged 7 commits into from
Feb 2, 2023

Conversation

Mikaayenson
Copy link
Contributor

@Mikaayenson Mikaayenson commented Jan 26, 2023

99435618-5c38a900-28de-11eb-9fdd-32cdc7d31196

Adds the o365.audit.NewValue field. It is present in the filebeat pipeline.js and available for use in a query (per the screenshot), but not defined in either Beats or the Elastic Agent integration mappings.

What does this PR do?

Updates the fields.yml to include the field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@Mikaayenson Mikaayenson added enhancement New feature or request Integration:o365 Microsoft Office 365 labels Jan 26, 2023
@Mikaayenson Mikaayenson requested a review from a team as a code owner January 26, 2023 16:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jan 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-02T03:17:29.355+0000

  • Duration: 14 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 12.5
Classes 100.0% (1/1) 💚 12.5
Methods 100.0% (16/16) 💚 16.484
Lines 82.155% (732/891) 👎 -10.559
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/o365/changelog.yml Outdated Show resolved Hide resolved
packages/o365/manifest.yml Outdated Show resolved Hide resolved
@Mikaayenson
Copy link
Contributor Author

@efd6 Anything else on this PR?

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Mikaayenson
Copy link
Contributor Author

👋 @efd6 For this the changelog shows that the minor has been already bumped by another Pr. Should I update the minor again or patch version?

@efd6
Copy link
Contributor

efd6 commented Feb 2, 2023

Bump the minor, 1.12.0.

@Mikaayenson Mikaayenson merged commit d4bce25 into main Feb 2, 2023
@elasticmachine
Copy link

Package o365 - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants