Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kibana] Add datastream period option #5201

Merged
merged 4 commits into from
Feb 10, 2023
Merged

[Kibana] Add datastream period option #5201

merged 4 commits into from
Feb 10, 2023

Conversation

crespocarlos
Copy link
Contributor

What does this PR do?

  • Add the period variable to each metrics data stream to enable granular polling frequency
  • Release the package to a GA version and set the metrics data streams as beta

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Build Kibana package
  • elastic-package stack up -v -d
  • Install Kibana package

Related issues

Screenshots

image

@crespocarlos crespocarlos added Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Feb 7, 2023
@crespocarlos crespocarlos mentioned this pull request Feb 7, 2023
Open
5 tasks
@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-10T09:00:24.064+0000

  • Duration: 28 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚 3.476
Classes 100.0% (4/4) 💚 3.476
Methods 94.872% (37/39) 👍 3.787
Lines 87.234% (82/94) 👎 -4.073
Conditionals 100.0% (0/0) 💚

@crespocarlos crespocarlos marked this pull request as ready for review February 7, 2023 14:33
@crespocarlos crespocarlos requested a review from a team as a code owner February 7, 2023 14:33
mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and LGTM

@crespocarlos crespocarlos merged commit bbfb39e into elastic:main Feb 10, 2023
bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
@crespocarlos @bhapas
[Kibana] Add datastream period option (elastic#5201)
25d79bb 
* Add datastream period option

* Update changelog

* Revert release:beta changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

Assignees
No one assigned
Labels
Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crespocarlos @elasticmachine @mohamedhamed-ahmed