Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Issues Datastream #5292

Merged
merged 20 commits into from
Feb 21, 2023
Merged

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Feb 15, 2023

What does this PR do?

Adds Issues datastream to Github package. With this users can ingest issues created across all repositories in an organisation or for specific repository.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Pipeline Tests

  • elastic-package stack down && elastic-package build && elastic-package stack up --version=8.6.0 -d -v --services=elasticsearch && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate --data-streams issues
Run pipeline tests for the package
--- Test results for package: github - START ---
╭─────────┬─────────────┬───────────┬─────────────────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME                   │ RESULT │ TIME ELAPSED │
├─────────┼─────────────┼───────────┼─────────────────────────────┼────────┼──────────────┤
│ github  │ issues      │ pipeline  │ test-github-issues-json.log │ PASS   │    31.8455ms │
╰─────────┴─────────────┴───────────┴─────────────────────────────┴────────┴──────────────╯
--- Test results for package: github - END   ---
Done

System Tests

  • elastic-package stack down && elastic-package build && elastic-package stack up --version=8.6.0 -d -v --services=elasticsearch && eval "$(elastic-package stack shellinit)" && elastic-package test system --generate --data-streams issues
Run system tests for the package
2023/02/16 15:00:38  INFO Write container logs to file: /Users/kcreddy/go/src/github.com/elastic/integrations/build/container-logs/github-1676539838164054000.log
--- Test results for package: github - START ---
╭─────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ github  │ issues      │ system    │ default   │ PASS   │ 26.937829917s │
╰─────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: github - END   ---
Done

Screenshots

Screenshot 2023-02-16 at 3 04 15 PM

@kcreddy kcreddy added enhancement New feature or request Integration:github GitHub labels Feb 15, 2023
@kcreddy kcreddy self-assigned this Feb 15, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-21T08:09:18.973+0000

  • Duration: 17 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (64/64) 💚
Lines 93.833% (989/1054) 👍 8.028
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review February 16, 2023 18:00
@kcreddy kcreddy requested a review from a team as a code owner February 16, 2023 18:00
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to modify based on comment above before merging, good job! 👍

@kcreddy kcreddy merged commit 68a4df6 into elastic:main Feb 21, 2023
@elasticmachine
Copy link

Package github - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=github

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
* add initial config

* add dashboards

* add labels

* more vis

* add changelog entry

* support additional params

* remove and refactor fields

* handle duplicate state

* update tags and version

* remove changelog todo

* add per_page param

* remove comments

* export issues dash

* add system test config

* update system tests to pass

* add user ecs fields

* sample event

* make dashboard compatible with 8.4

* update event ecs
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
* add initial config

* add dashboards

* add labels

* more vis

* add changelog entry

* support additional params

* remove and refactor fields

* handle duplicate state

* update tags and version

* remove changelog todo

* add per_page param

* remove comments

* export issues dash

* add system test config

* update system tests to pass

* add user ecs fields

* sample event

* make dashboard compatible with 8.4

* update event ecs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:github GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants