Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image sources in Tines readme #5415

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Fix image sources in Tines readme #5415

merged 3 commits into from
Feb 28, 2023

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Feb 28, 2023 •
edited
Loading

The Tines integration screenshot sources are incorrect. This PR fixes them so the screenshots will correctly render in Kibana and our documentation.

@bmorelli25 bmorelli25 requested a review from a team as a code owner February 28, 2023 17:42
@bmorelli25 bmorelli25 self-assigned this Feb 28, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Feb 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-28T18:34:47.945+0000

  • Duration: 15 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.216
Classes 100.0% (2/2) 💚 3.216
Methods 91.304% (21/23) 👍 0.128
Lines 82.474% (160/194) 👎 -9.535
Conditionals 100.0% (0/0) 💚

bhapas
bhapas approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit 34e722e into elastic:main Feb 28, 2023
@bmorelli25 bmorelli25 deleted the tines-imgs branch February 28, 2023 19:28
@elasticmachine
Copy link

Package tines - 0.0.2 containing this change is available at https://epr.elastic.co/search?package=tines

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@bmorelli25 @agithomas
Fix image sources in Tines readme (elastic#5415)
955f458 
* fix img links

* Update packages/tines/changelog.yml

* Update packages/tines/changelog.yml
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@bmorelli25 @agithomas
Fix image sources in Tines readme (elastic#5415)
abb3dde 
* fix img links

* Update packages/tines/changelog.yml

* Update packages/tines/changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
Integration:tines Tines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmorelli25 @elasticmachine @bhapas @jamiehynds