-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fortinet_fortimanager] Update an integration for syslog support #5432
[fortinet_fortimanager] Update an integration for syslog support #5432
Conversation
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this file since it is no longer generated data. Suggest name after the version of FortiOS that was the source of the events.
field: message | ||
target_field: event.original | ||
ignore_missing: true | ||
- grok: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With failable processors it's helpful for debugging to include tags and include those in the appended error message. See discussion here and related proposal here. This adds human/user friendly messages and programmatically amenable tags to error.message
. In this particular case it's not so crucial, but there are a few date
s and several convert
s below that would be easier to differentiate with this approach, so I'd suggest doing it for all the failable processors here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efd6, make sense will follow the same and update PR soon. Also do we have any preferred format so that we can follow consistency across all the integration. Some ideas are , consider we have 2 grok processors we can use grok_1 and grok_2 else we can use format {{processor_name_from_source_field_to_target_field}} , let me know.
Package fortinet_fortimanager - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortimanager |
What does this PR do?
Integration release checklist
This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.
All changes
New Package
Dashboards changes
Log dataset changes
How to test this PR locally
Screenshots