-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1Password] Add 1Password Events API Audit Events #5496
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
packages/1password/data_stream/audit_events/agent/stream/httpjson.yml.hbs
Outdated
Show resolved
Hide resolved
packages/1password/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/1password/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/1password/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
/test |
Can you provide a link to the auditevents API and describe the provenance of the test cases (constructed/sanitised/etc). |
🌐 Coverage report
|
packages/1password/kibana/dashboard/1password-audit-events-full-dashboard.json
Show resolved
Hide resolved
Thanks for the review! The events API audit events data streaming has not been released yet, so I don't have any links or documentations for this right now, but the API is scheduled to be released on Mar 15, so I'll have the documentations available by then. The test data were created with a local development build of the Events API with local test data. |
@anthonythleung Thanks for that. I'll ping here late March if we don't have them by then. |
/test |
@efd6 The audit events API has now been released and the documentations are available here: https://developer.1password.com/docs/events-api/reference/#post-apiv1auditevents |
The agent is complaining:
It looks like you are missing an endpoint addition to the docker/config.yml. |
/test |
1 similar comment
/test |
Sorry, a conflicting change has been made. Would you please resolve the conflict. Ping me when it's done so I won't miss a window. It all looks good to me after that is done. |
packages/1password/data_stream/audit_events/_dev/test/system/test-default-config.yml
Show resolved
Hide resolved
packages/1password/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
@efd6 I've resolved the merge conflicts and addressed the comments above. Thanks! |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Package 1password - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=1password |
What does this PR do?
This PR adds a new audit events data stream to the 1Password Elastic integration.
Checklist
changelog.yml
file.Screenshots