Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1Password] Add 1Password Events API Audit Events #5496

Merged
merged 10 commits into from
Mar 23, 2023

Conversation

anthonythleung
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds a new audit events data stream to the 1Password Elastic integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

image

@anthonythleung anthonythleung requested a review from a team as a code owner March 9, 2023 16:59
@elasticmachine
Copy link

elasticmachine commented Mar 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T20:37:09.112+0000

  • Duration: 16 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added Integration:1password 1Password enhancement New feature or request labels Mar 9, 2023
@efd6
Copy link
Contributor

efd6 commented Mar 10, 2023

/test

@efd6
Copy link
Contributor

efd6 commented Mar 10, 2023

Can you provide a link to the auditevents API and describe the provenance of the test cases (constructed/sanitised/etc).

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.049
Classes 100.0% (3/3) 💚 3.049
Methods 90.909% (30/33) 👎 -0.632
Lines 87.888% (283/322) 👎 -4.529
Conditionals 100.0% (0/0) 💚

@anthonythleung
Copy link
Contributor Author

Can you provide a link to the auditevents API and describe the provenance of the test cases (constructed/sanitised/etc).

Thanks for the review! The events API audit events data streaming has not been released yet, so I don't have any links or documentations for this right now, but the API is scheduled to be released on Mar 15, so I'll have the documentations available by then. The test data were created with a local development build of the Events API with local test data.

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2023

@anthonythleung Thanks for that. I'll ping here late March if we don't have them by then.

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2023

/test

@anthonythleung
Copy link
Contributor Author

@efd6 The audit events API has now been released and the documentations are available here: https://developer.1password.com/docs/events-api/reference/#post-apiv1auditevents

@efd6
Copy link
Contributor

efd6 commented Mar 15, 2023

The agent is complaining:

2023-03-16 09:45:11 {"log.level":"error","@timestamp":"2023-03-15T23:15:11.961Z","message":"Error while processing http request: failed to execute rf.collectResponse: failed to execute http client.Do: server responded with status code 404: ","component":{"binary":"filebeat","dataset":"elastic_agent.filebeat","id":"httpjson-default","type":"httpjson"},"log":{"source":"httpjson-default"},"ecs.version":"1.6.0","log.logger":"input.httpjson-cursor","log.origin":{"file.line":135,"file.name":"httpjson/input.go"},"id":"httpjson-1password.audit_events-23c79f8b-96db-46c4-a472-ae89233f01ff","input_source":"http://elastic-package-service_1password_eventsapi_mock_1:8080/api/v1/auditevents","service.name":"filebeat","input_url":"http://elastic-package-service_1password_eventsapi_mock_1:8080/api/v1/auditevents","ecs.version":"1.6.0"}

It looks like you are missing an endpoint addition to the docker/config.yml.

@efd6
Copy link
Contributor

efd6 commented Mar 22, 2023

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Mar 23, 2023

/test

@efd6
Copy link
Contributor

efd6 commented Mar 23, 2023

Sorry, a conflicting change has been made. Would you please resolve the conflict. Ping me when it's done so I won't miss a window. It all looks good to me after that is done.

@anthonythleung
Copy link
Contributor Author

@efd6 I've resolved the merge conflicts and addressed the comments above. Thanks!

@efd6
Copy link
Contributor

efd6 commented Mar 23, 2023

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@efd6 efd6 merged commit 32be741 into elastic:main Mar 23, 2023
@elasticmachine
Copy link

Package 1password - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=1password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:1password 1Password
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants