Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortinet_fortigate: accomodate multiple and misformatted timezones #5554

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fortinet_fortigate: accomodate multiple and misformatted timezones #5554

merged 1 commit into from
Mar 16, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 15, 2023

What does this PR do?

Allows ingestion of logs with multiple tz fields and timezones with invalid formats.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Mar 15, 2023
@efd6 efd6 self-assigned this Mar 15, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T04:50:46.305+0000

  • Duration: 16 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.459
Classes 100.0% (4/4) 💚 3.459
Methods 100.0% (38/38) 💚 9.063
Lines 92.39% (1129/1222) 👍 1.011
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 15, 2023 22:50
@efd6 efd6 requested a review from a team as a code owner March 15, 2023 22:50
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict resolution before merging. LGTM

@efd6 efd6 merged commit 502c601 into elastic:main Mar 16, 2023
@elasticmachine
Copy link

Package fortinet_fortigate - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@efd6 @agithomas
fortinet_fortigate: accomodate multiple and misformatted timezones (e…
b1f81cc 
…lastic#5554)
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 @agithomas
fortinet_fortigate: accomodate multiple and misformatted timezones (e…
cacd6ba 
…lastic#5554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy