Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflare_logpush: use EdgeStartTimestamp event timestamp #5599

Merged
merged 1 commit into from
Mar 21, 2023
Merged

cloudflare_logpush: use EdgeStartTimestamp event timestamp #5599

merged 1 commit into from
Mar 21, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 21, 2023 •
edited
Loading

What does this PR do?

Use a consistent and meaningful timestamp for events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Mar 21, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T00:29:44.468+0000

  • Duration: 20 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (89/89) 💚 9.709
Lines 94.378% (2384/2526) 👎 -1.622
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 21, 2023 01:32
@efd6 efd6 requested a review from a team as a code owner March 21, 2023 01:32
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

bhapas
bhapas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 35f9966 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package cloudflare_logpush - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

@travisestill travisestill mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare Logpush - http_request ingest pipeline does not set @Timestamp
3 participants
@efd6 @elasticmachine @bhapas