Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beat] fix cgroup memory aliases #5639

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Mar 22, 2023

Add missing cgroup memory aliases from this change elastic/elasticsearch#94400

Related elastic/kibana#153123

@klacabane klacabane added Integration:beat Beat Feature:Stack Monitoring Stack Monitoring Feature labels Mar 22, 2023
@klacabane klacabane self-assigned this Mar 22, 2023
@klacabane klacabane added the bug Something isn't working, use only for issues label Mar 22, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-22T16:27:18.355+0000

  • Duration: 17 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.125
Classes 100.0% (0/0) 💚 3.125
Methods 100.0% (6/6) 💚 8.659
Lines 100.0% (0/0) 💚 7.957
Conditionals 100.0% (0/0) 💚

@klacabane klacabane marked this pull request as ready for review March 22, 2023 16:27
@klacabane klacabane requested a review from a team as a code owner March 22, 2023 16:27
@klacabane klacabane added the Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services label Mar 22, 2023
@klacabane klacabane merged commit f68a57a into elastic:main Mar 23, 2023
@elasticmachine
Copy link

Package beat - 0.1.3 containing this change is available at https://epr.elastic.co/search?package=beat

klacabane added a commit to elastic/kibana that referenced this pull request Mar 23, 2023
Closes #153123

### Summary
elastic/elasticsearch#94400 added missing
aliases required by Stack Monitoring. Tests started to fail as they
expected the metrics related to these aliases to be empty since they
could not be queried, but now return associated data.
I've generated a new archive and updated the tests accordingly.

Tests use package build from
elastic/integrations#5639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Feature:Stack Monitoring Stack Monitoring Feature Integration:beat Beat Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants