Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Traefik] Lens migration for visualizations to Kibana version 8.0.0 #5693

Merged
merged 4 commits into from
Apr 3, 2023
Merged

[O11y][Traefik] Lens migration for visualizations to Kibana version 8.0.0 #5693

merged 4 commits into from
Apr 3, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 27, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Traefik integration package

  • Statistics for Traefik Lens migration:

Traefik dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs Traefik] Access logs 0 5 5 0
  0 5 5 0

Note: Below are the two visualizations which have not been migrated

  Visualisation Name Link to the issue
[Logs Traefik] Access logs Sent Byte Size [Logs Traefik] elastic/kibana#124279

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.0.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 27, 2023 07:17
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 27, 2023
Closed
5 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 27, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T07:19:28.747+0000

  • Duration: 18 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.27
Classes 100.0% (3/3) 💚 3.27
Methods 100.0% (26/26) 💚 8.217
Lines 97.696% (212/217) 👍 6.387
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

image

How many top URLs are planned to be shown? If top is 10, Will the new pie charts load automatically?

@SubhrataK , What is your feedback on this ? Is a simple table representation be a suitable replacement ?

@SubhrataK
Copy link

image

How many top URLs are planned to be shown? If top is 10, Will the new pie charts load automatically?

@SubhrataK , What is your feedback on this ? Is a simple table representation be a suitable replacement ?

Please replace this with a table.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 28, 2023
Closed
9 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:traefik Traefik v8.0.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 28, 2023
@rajvi-patel-22
Copy link
Contributor Author

Please replace this with a table.

We have migrated this panel to table in lens as suggested and updated the PR.
kibana-traefik

@agithomas
Copy link
Contributor

Please replace this with a table.

We have migrated this panel to table in lens as suggested and updated the PR. kibana-traefik

Are the columns fixed ? Does more columns automatically add with new errors such as 500, 403, 201 for the endpoints in the row?

@rajvi-patel-22
Copy link
Contributor Author

Are the columns fixed ? Does more columns automatically add with new errors such as 500, 403, 201 for the endpoints in the row?

@agithomas, No the columns are not fixed. At most 5 columns will be added with new error codes because the older visualization also represented Top 5 error codes.

@agithomas
Copy link
Contributor

@agithomas, No the columns are not fixed. At most 5 columns will be added with new error codes because the older visualization also represented Top 5 error codes.

Thanks for clarifying

@kush-elastic kush-elastic mentioned this pull request Mar 29, 2023
Closed
36 tasks
@agithomas
Copy link
Contributor

@rajvi-elastic , i see one of the visualisation is not migrated to Lens. Can you name the panel please that is not migrated. I see an issue linked and what i am not sure is - if the issue is big enough not to do a Lens migration. Hope you can clarify with details.

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Mar 30, 2023 •
edited
Loading

@rajvi-elastic , i see one of the visualisation is not migrated to Lens. Can you name the panel please that is not migrated. I see an issue linked and what i am not sure is - if the issue is big enough not to do a Lens migration. Hope you can clarify with details.

@agithomas , Below panel (Sent Byte Size [Logs Traefik]) is not migrated to the lens due to Dot Size metric.
image

Dot Size shows you dots (Filled circles) for your aggregation with different sizes which is based on the metric value.

For example in above panel, the circles represent the count of documents and each circle has different size according to doc count.

Sent.Byte.Size.Logs.Traefik.-.Elastic.-.Google.Chrome.2023-03-30.09-39-11.mp4

This functionality is not supported by lens and we also didn't find any workaround for this.

@agithomas
Copy link
Contributor

@SubhrataK , can you please review this ? I do not know if the dot size really matter since it is not a scatter plot and there exist a Y -axis. A right side y-axis (in addition to the left side Y-axis displaying the Data sent) can be added to display the count , if needed, as an alternative.

@rajvi-patel-22
Copy link
Contributor Author

As discuss with @SubhrataK, we will add right X-Axis which shows count of records in the form of line chart.

@rajvi-patel-22
Copy link
Contributor Author

As discuss with @SubhrataK, we will add right X-Axis which shows count of records in the form of line chart.

@agithomas, Please find below screenshot for Sent Byte Size [Logs Traefik] panel.
kibana-traefik

PR has been updated and all the panels have been migrated to lens.

agithomas
agithomas approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kush-elastic
kush-elastic approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit b851c1f into elastic:main Apr 3, 2023
@elasticmachine
Copy link

Package traefik - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=traefik

@milan-elastic milan-elastic mentioned this pull request Jun 8, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:traefik Traefik Team:Service-Integrations Label for the Service Integrations team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @SubhrataK @kush-elastic