Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_umbrella] Fix indentation #5784

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Apr 4, 2023

What does this PR do?

Fixes an indentation error that disables configuration of the integration in Kibana.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner April 4, 2023 09:57
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-04T10:08:59.289+0000

  • Duration: 13 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Apr 4, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 95.238% (20/21) 👍
Lines 94.805% (511/539) 👍
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit ed041f2 into elastic:main Apr 4, 2023
@LaZyDK LaZyDK deleted the umbrella-indent-fix branch April 4, 2023 10:55
@elasticmachine
Copy link

Package cisco_umbrella - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants