Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSDB] Couchdb add dimension fields #5855

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner April 11, 2023 11:59
@agithomas agithomas force-pushed the issue-5854-couchdb-tsdb-dim-server branch from 894c441 to b57ad47 Compare April 11, 2023 12:01
@agithomas agithomas mentioned this pull request Apr 11, 2023
6 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-11T12:03:11.479+0000

  • Duration: 15 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (7/7) 💚 33.333
Lines 94.175% (194/206) 👎 -0.011
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 0af9bc0 into elastic:main Apr 12, 2023
@elasticmachine
Copy link

Package couchdb - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=couchdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants