Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulse_connect_secure: allow user-defined TCP options #5887

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 17, 2023

What does this PR do?

This add a TCP options configuration field that allows users to pass parameters to the TCP input. This is important to allow setting framing options.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Apr 17, 2023
@efd6 efd6 force-pushed the 5861-pulse_connect_secure branch from c2a3099 to e0dac01 Compare April 17, 2023 00:24
@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-17T00:24:53.952+0000

  • Duration: 17 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚
Lines 90.984% (111/122)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 17, 2023 01:20
@efd6 efd6 requested a review from a team as a code owner April 17, 2023 01:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 5bb30be into elastic:main Apr 18, 2023
@elasticmachine
Copy link

Package pulse_connect_secure - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=pulse_connect_secure

bhapas pushed a commit to bhapas/integrations that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:pulse_connect_secure Pulse Connect Secure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pulse-connect-secure] Add tcp_options parameter
3 participants