-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS][ECS] Add dimension fields for TSDB support #5895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
constanca-m
requested review from
tetianakravchenko,
lalit-satapathy,
agithomas and
ritalwar
April 17, 2023 08:42
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
5 tasks
constanca-m
force-pushed
the
add-metric-type-ecs
branch
from
April 24, 2023 07:13
2362c1f
to
4a3cb34
Compare
tetianakravchenko
approved these changes
May 2, 2023
kaiyan-sheng
approved these changes
May 3, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Package aws - 1.34.1 containing this change is available at https://epr.elastic.co/search?package=aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add dimension fields to ECS datastream.
Details
To uniquely identify an ECS resource we need the service name, unique per cluster. Since we can have two clusters with the same name in the same account, we also need to set the region as dimension. There are no metrics split by labels, which make these fields be the only ones needed as a dimension.
Checklist
changelog.yml
file.How to test this PR locally
Refer to #5894
Related issues