Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][ECS] Add dimension fields for TSDB support #5895

Merged
merged 5 commits into from
May 4, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Apr 17, 2023

What does this PR do?

Add dimension fields to ECS datastream.

Details

To uniquely identify an ECS resource we need the service name, unique per cluster. Since we can have two clusters with the same name in the same account, we also need to set the region as dimension. There are no metrics split by labels, which make these fields be the only ones needed as a dimension.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #5894

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-03T15:32:19.060+0000

  • Duration: 54 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.202
Classes 93.75% (15/16) 👎 -3.202
Methods 86.131% (236/274) 👎 -5.526
Lines 85.925% (7387/8597) 👎 -6.066
Conditionals 100.0% (0/0) 💚

constanca-m and others added 3 commits May 3, 2023 17:26
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit 5cd25a7 into elastic:main May 4, 2023
@constanca-m constanca-m deleted the add-metric-type-ecs branch May 4, 2023 07:04
@elasticmachine
Copy link

Package aws - 1.34.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants