Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: fix flows dashboard #5903

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 17, 2023

What does this PR do?

Previously the flows dashboard complained that it did not have an associated data view, so re-save after adding the logs-* data view.

Also add and canonicalise dashboard descriptions for assets page.

Kibana version of dashbaords is bumped to 8.5.3, reasonably recent to reduce upgrade shock in future when converting to lens, but not losing access for users who are not yet on 8.7.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-04-18 at 09 14 26

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels Apr 17, 2023
@efd6 efd6 self-assigned this Apr 17, 2023
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.12.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump minor rather than patch due to kibana version change.

Previously the flows dashboard complained that it did not have an associated
data view, so re-save after adding the logs-* data view.

Also add and canonicalise dashboard descriptions for assets page.

Kibana version of dashbaords is bumped to 8.5.3, reasonably recent to reduce
upgrade shock in future when converting to lens, but not losing access for users
who are not yet on 8.7.
@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-17T23:56:05.408+0000

  • Duration: 79 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 178
Skipped 0
Total 178

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (48/64) 👎 -16.525
Lines 100.0% (0/0) 💚 9.201
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 18, 2023 02:15
@efd6 efd6 requested a review from a team as a code owner April 18, 2023 02:15
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 7f4a623 into elastic:main Apr 18, 2023
@elasticmachine
Copy link

Package network_traffic - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic

bhapas pushed a commit to bhapas/integrations that referenced this pull request Apr 19, 2023
Previously the flows dashboard complained that it did not have an associated
data view, so re-save after adding the logs-* data view.

Also add and canonicalise dashboard descriptions for assets page.

Kibana version of dashbaords is bumped to 8.5.3, reasonably recent to reduce
upgrade shock in future when converting to lens, but not losing access for users
who are not yet on 8.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants