Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: update tests expectations to match processor behaviour #5964

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 23, 2023

What does this PR do?

This updates the tests expectations to match the bahaviour of ES ingest processors.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • This unfortunately requires dropping support for 7.x stacks. The alternative would be to reimplement the registered_domain processor behaviour for 7.x which I think would be unreasonably brittle.

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Apr 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-23T23:31:07.777+0000

  • Duration: 17 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.516% (76/91) 👎 -16.484
Lines 92.748% (5103/5502) 👎 -2.535
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 23, 2023 23:59
@efd6 efd6 requested review from a team as code owners April 23, 2023 23:59
@efd6 efd6 requested review from belimawr and leehinman April 23, 2023 23:59
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 248fb15 into elastic:main Apr 24, 2023
@elasticmachine
Copy link

Package windows - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:windows Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows] sysmon/operational registered_domain test failures
3 participants