Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Fix Pod dashboard, remove 2 visualisation to migrate to TSDB #6171

Merged

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

Pod: use last_value instead of average. For counter average is not supported
Api server:

  • remove 2 visualisation, because now when the aggregation was changed sum -> max we need to break it down by multiple fields, but the current limit is 4. Also it is indeed is quite a lot data per one visualisation, we need to rethink current visualisation

TODO:

  • create an issue to readd removed visualisation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

This includes both non-TSDB and TSDB data
Screenshot 2023-05-11 at 20 15 51

Screenshot 2023-05-11 at 20 15 04

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.38.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally should be merged after #5992

@elasticmachine
Copy link

elasticmachine commented May 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-12T07:40:23.136+0000

  • Duration: 28 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.983
Classes 100.0% (0/0) 💚 2.983
Methods 96.154% (75/78) 👍 4.466
Lines 100.0% (0/0) 💚 7.956
Conditionals 100.0% (0/0) 💚

@ruflin
Copy link
Member

ruflin commented May 12, 2023

we need to break it down by multiple fields, but the current limit is 4.

Is this a Lens specific limitation? Is this something that should get removed?

@tetianakravchenko
Copy link
Contributor Author

we need to break it down by multiple fields, but the current limit is 4.
Is this a Lens specific limitation? Is this something that should get removed?

yes, seems to be Lens specific, there is max 4 fields for the Breakdown, then Add field becomes inactive:
Screenshot 2023-05-15 at 09 15 27

I would create a different issue and investigate how/if possible to reorganize those visualisation

@ruflin
Copy link
Member

ruflin commented May 15, 2023

@tetianakravchenko Can you file a Kibana issue on this one if this needs changing in the future? #6171 (comment)

@tetianakravchenko tetianakravchenko merged commit ebc49f7 into elastic:main May 15, 2023
@tetianakravchenko tetianakravchenko deleted the k8s-dashboards-pod-apiserver branch May 15, 2023 10:25
@elasticmachine
Copy link

Package kubernetes - 1.38.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants