Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes][Dashboards] Fix proxy, controller manager and scheduler incorrect visualizations and add use of last value #6196

Merged
merged 6 commits into from
May 15, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

This PR is a follow up to #5992. Main changes are:

  1. Formulas involving counter fields use last_value aggregation again, since it is supported again for these.
  2. Add sort field that was missing in the 3 dashboards:
    image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this May 15, 2023
@constanca-m constanca-m requested review from a team as code owners May 15, 2023 09:41
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented May 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-15T10:50:33.866+0000

  • Duration: 30 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

constanca-m and others added 3 commits May 15, 2023 12:15
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@tetianakravchenko
Copy link
Contributor

tetianakravchenko commented May 15, 2023

@gizas regarding your comment on naming in previous PR: #5992 (comment)
I think it was resolved? because those changes are affecting only the counter metrics

@tetianakravchenko
Copy link
Contributor

@gizas regarding your comment on naming in previous PR: #5992 (comment)
I think it was resolved? because those changes are affecting only the counter metrics

@gizas
I will merge this PR, but if there is needed any follow up on it, please let me know

@tetianakravchenko tetianakravchenko merged commit 2878def into elastic:main May 15, 2023
@elasticmachine
Copy link

Package kubernetes - 1.38.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@constanca-m constanca-m deleted the fix-k8s-dashboards branch May 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants