Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vsphere] Add dimensions field mapping for host datastream to suppo… #6306

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented May 24, 2023

  • Enhancement

What does this PR do?

This PR adds dimension field mapping for Vsphere host data stream to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request May 24, 2023
16 tasks
@ritalwar ritalwar marked this pull request as ready for review May 24, 2023 10:20
@ritalwar ritalwar requested a review from a team as a code owner May 24, 2023 10:20
@elasticmachine
Copy link

elasticmachine commented May 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T05:35:37.020+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚
Lines 89.13% (41/46) 👎 -4.685
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar changed the title [Vsphere] Added dimensions field mapping for host datastream to suppo… [Vsphere] Add dimensions field mapping for host datastream to suppo… May 30, 2023
@ritalwar ritalwar requested a review from a team as a code owner May 30, 2023 05:41
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 9a407ea into elastic:main Jun 1, 2023
@elasticmachine
Copy link

Package vsphere - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=vsphere

agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
…lastic#6306)

* [Vsphere] Add dimensions field mapping for host datastream to support TSDB.
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
…6306)

* [Vsphere] Add dimensions field mapping for host datastream to support TSDB.
@andrewkroh andrewkroh added the Integration:vsphere VMware vSphere label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:vsphere VMware vSphere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants