Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_meraki] - Update to package-spec 2.7.0 #6439

Merged
merged 2 commits into from
Jun 2, 2023
Merged

[cisco_meraki] - Update to package-spec 2.7.0 #6439

merged 2 commits into from
Jun 2, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jun 1, 2023 •
edited
Loading

What does this PR do?

Updates package-spec version to 2.7.0

  • Normalized observer.mac to array.
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0 packages/cisco_meraki

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_meraki
elastic-package test

Related issues

  • Relates elastic/security-team#5870

@taylor-swanson
[cisco_meraki] - Update to package-spec 2.7.0
274da80 
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0packages/cisco_meraki
@taylor-swanson taylor-swanson self-assigned this Jun 1, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T21:23:12.572+0000

  • Duration: 17 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (65/65) 💚
Lines 98.043% (1102/1124) ❕
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review June 1, 2023 21:42
@taylor-swanson taylor-swanson requested a review from a team as a code owner June 1, 2023 21:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit 2dbd59f into elastic:main Jun 2, 2023
@taylor-swanson taylor-swanson deleted the pkg-spec-cisco_meraki branch June 2, 2023 12:53
@elasticmachine
Copy link

Package cisco_meraki - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@taylor-swanson @sodhikirti07
[cisco_meraki] - Update to package-spec 2.7.0 (#6439)
98348da 
Updates package-spec version to 2.7.0

- Normalized `observer.mac` to array.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0 packages/cisco_meraki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:cisco_meraki Cisco Meraki
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylor-swanson @elasticmachine @efd6