Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveMQ added dimensions for broker datastream #6484

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

What does this PR do?

Added TSDB dimensions related changes for ActiveMQ package, broker datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@agithomas agithomas marked this pull request as ready for review June 6, 2023 05:13
@agithomas agithomas requested a review from a team as a code owner June 6, 2023 05:13
@elasticmachine
Copy link

elasticmachine commented Jun 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-06T05:13:51.588+0000

  • Duration: 19 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.958
Classes 100.0% (2/2) 💚 2.958
Methods 95.833% (23/24) 👍 4.034
Lines 85.321% (93/109) 👎 -6.74
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 7d3e6ac into elastic:main Jun 6, 2023
@elasticmachine
Copy link

Package activemq - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=activemq

@agithomas agithomas mentioned this pull request Jun 6, 2023
11 tasks
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
* ActiveMQ added dimensions for broker datastream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants