[okta] Fix concurrent modification exception #6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
andrewkroh
force-pushed
the
okta/bugfix/concurrent-mod-exception
branch
from
0890944
to
ebd8a63
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Use the entrySet().removeIf() lambda to perform the remove operation on a map instead of calling remove() on the map while looping over the entrySet() items. Fixes elastic#6506
[git-generate] cd packages/okta elastic-package changelog add --link elastic#6507 --next patch --type bugfix --description "Fix a concurrent modification exception that occurred while modifying okta.target[].detailEntry."
andrewkroh
force-pushed
the
okta/bugfix/concurrent-mod-exception
branch
from
ebd8a63
to
e94273c
Compare
efd6
approved these changes
Jun 7, 2023
Comment on lines
+568
to
+570
| de.entrySet().removeIf(entry -> | ||
| entry.getKey() != "methodTypeUsed" && | ||
| entry.getKey() != "methodUsedVerifiedProperties"); |
There was a problem hiding this comment.
Go has spoiled me with map iteration (3.) and elem deletion.
packages/okta/data_stream/system/_dev/test/pipeline/test-okta-system-events.log
Outdated
Show resolved
Hide resolved
|
Package okta - 1.22.1 containing this change is available at https://epr.elastic.co/search?package=okta |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
Use the entrySet().removeIf() lambda to perform the remove operation on a map instead of calling remove() on the map while looping over the entrySet() items. Fixes #6506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the entrySet().removeIf() lambda to perform the remove operation on a map instead of calling remove() on the map while looping over the entrySet() items.
Fixes #6506
Checklist
changelog.ymlfile.