-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network_traffic] Fix to index events with memcached stats responses #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisberkhout
added
bug
Something isn't working, use only for issues
Team:Security-External Integrations
Integration:network_traffic
Network Packet Capture
labels
Jun 12, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
chrisberkhout
force-pushed
the
network-traffic-memcache-stats-fix
branch
from
June 12, 2023 13:23
a0646d7
to
fce45d9
Compare
chrisberkhout
added
bugfix
Pull request that fixes a bug issue
and removed
bug
Something isn't working, use only for issues
labels
Jun 12, 2023
...twork_traffic/data_stream/memcached/_dev/test/system/test-memcached-bin-tcp-stats-config.yml
Show resolved
Hide resolved
...work_traffic/data_stream/memcached/_dev/test/system/test-memcached-text-tcp-stats-config.yml
Show resolved
Hide resolved
chrisberkhout
force-pushed
the
network-traffic-memcache-stats-fix
branch
from
June 14, 2023 14:32
5a51ed8
to
5a55088
Compare
💚 Build Succeeded
History
|
efd6
reviewed
Jun 19, 2023
packages/network_traffic/data_stream/memcached/_dev/test/pipeline/test-stats-responses.json
Outdated
Show resolved
Hide resolved
chrisberkhout
force-pushed
the
network-traffic-memcache-stats-fix
branch
from
June 22, 2023 11:41
5a55088
to
1a4c80a
Compare
taylor-swanson
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
efd6
approved these changes
Jun 22, 2023
Package network_traffic - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=network_traffic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Network Packet Capture integration to not drop events with memcached
STATS
response data, by using a flattened field to hold the stats data in a single object.Details
The Network Packet Capture integration currently fails to index events with memcached
STATS
response data,as described in issue #6230.
The stats data in the event is an array of objects with
name
andvalue
keys:Many stat names are listed in the memcached documentation (93 general-purpose statistics, and over 100 others). However, actual responses may include fewer, or additional (undocumented) stats.
Since the purpose of the integration is to sniff network packets and dissect known protocols, rather than to support monitoring and operation of memcached clusters, I chose to index the stats data as a single flattened object, which makes the data readable although not easily queryable:
Alternative representations could be more queryable, but at the cost of indexing many additional documents (nested), or mapping a large and changeable number of fields.
Checklist
changelog.yml
file.Related issues