Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zoom] Ensure event.kind is correctly set for pipeline errors #6653

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

MakoWish
Copy link
Contributor

What does this PR do?

Modify zoom integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 21, 2023 22:43
@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T22:49:18.252+0000

  • Duration: 15 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 21, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (10/10) 💚
Classes 100.0% (10/10) 💚
Methods 96.226% (51/53) 👎 -0.673
Lines 89.889% (889/989) 👎 -5.37
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 169db53 into elastic:main Jun 21, 2023
@elasticmachine
Copy link

Package zoom - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=zoom

@MakoWish MakoWish deleted the 6582-zoom branch June 22, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants