Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Update cis gcp config file #6687

Merged
merged 3 commits into from
Jun 25, 2023
Merged

[Cloud Security] Update cis gcp config file #6687

merged 3 commits into from
Jun 25, 2023

Conversation

uri-weisman
Copy link
Contributor

What does this PR do?

Update the cis_gcp hbs file to reflect the auth options we'll support in GCP.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@uri-weisman uri-weisman added the enhancement New feature or request label Jun 25, 2023
@uri-weisman uri-weisman requested a review from a team as a code owner June 25, 2023 10:31
@elasticmachine
Copy link

elasticmachine commented Jun 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-25T13:02:25.648+0000

  • Duration: 16 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.769
Classes 100.0% (0/0) 💚 2.769
Methods 25.0% (2/8) 👎 -68.154
Lines 100.0% (0/0) 💚 8.415
Conditionals 100.0% (0/0) 💚

kfirpeled
kfirpeled approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uri-weisman uri-weisman merged commit 7a2964e into elastic:main Jun 25, 2023
@uri-weisman uri-weisman deleted the support_cis_gcp branch June 25, 2023 16:08
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@uri-weisman uri-weisman linked an issue Jun 26, 2023 that may be closed by this pull request
Modify CIS GCP hbs file to support new auth methods #5354
Closed
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview20 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview21 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview22 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview23 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview24 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview25 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview26 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview27 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify CIS GCP hbs file to support new auth methods
4 participants
@uri-weisman @elasticmachine @kfirpeled @andrewkroh