-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[haproxy] Add event.duration to log's exported fields section #6727
Conversation
[git-generate] cd packages/haproxy elastic-package changelog add --link #6727 --next patch --type bugfix --description "Add missing event.duration field mapping."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That table in README.md is generated based on the fields/*.yml
files. So I added event.duration
to the ecs.yml
file. Then I added a changelog entry for this as well. That should made the PR ready to merge after a review from the owning team.
🌐 Coverage report
|
@andrewkroh Thank you very much. That's what I didn't know and needed to spend time to research. Thanks to you I got more one piece of knowledge. I appriciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please resolve conflicts and merge
Package haproxy - 1.7.2 containing this change is available at https://epr.elastic.co/search?package=haproxy |
event.duration
is available based on the ingest pipeline.What does this PR do?
Just complement missing
event.duration
in the HAProxy integration's doc.I leave the sentence
If event.start and event.end are known this value should be the difference between the end and start time.
because it looks common among all README's.Checklist
changelog.yml
file. I don't think this is needed but let me know if I should bump up the HAProxy integration's version as a part of this PR.How to test this PR locally
n/a; just a doc PR.
Related issues
n/a