Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haproxy] Add event.duration to log's exported fields section #6727

Merged
merged 4 commits into from
Jul 1, 2023

Conversation

sakurai-youhei
Copy link
Member

event.duration is available based on the ingest pipeline.

What does this PR do?

Just complement missing event.duration in the HAProxy integration's doc.

I leave the sentence If event.start and event.end are known this value should be the difference between the end and start time. because it looks common among all README's.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file. I don't think this is needed but let me know if I should bump up the HAProxy integration's version as a part of this PR.

How to test this PR locally

n/a; just a doc PR.

Related issues

n/a

@sakurai-youhei sakurai-youhei added bug Something isn't working, use only for issues documentation Improvements or additions to documentation labels Jun 28, 2023
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner June 28, 2023 05:00
@elasticmachine
Copy link

elasticmachine commented Jun 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-01T00:20:46.741+0000

  • Duration: 14 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@sakurai-youhei sakurai-youhei marked this pull request as draft June 28, 2023 05:18
@andrewkroh andrewkroh changed the title Add event.duration to log's exported fields section [haproxy] Add event.duration to log's exported fields section Jun 29, 2023
[git-generate]
cd packages/haproxy
elastic-package changelog add --link #6727 --next patch --type bugfix --description "Add missing event.duration field mapping."
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That table in README.md is generated based on the fields/*.yml files. So I added event.duration to the ecs.yml file. Then I added a changelog entry for this as well. That should made the PR ready to merge after a review from the owning team.

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 90.476% (19/21) 👍
Lines 97.297% (180/185) 👍
Conditionals 100.0% (0/0) 💚

@sakurai-youhei sakurai-youhei marked this pull request as ready for review June 30, 2023 03:30
@sakurai-youhei
Copy link
Member Author

@andrewkroh Thank you very much. That's what I didn't know and needed to spend time to research. Thanks to you I got more one piece of knowledge. I appriciate it!

@ishleenk17 ishleenk17 added the Team:Service-Integrations Label for the Service Integrations team label Jun 30, 2023
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please resolve conflicts and merge

@sakurai-youhei sakurai-youhei merged commit 8ed4f4e into main Jul 1, 2023
@elasticmachine
Copy link

Package haproxy - 1.7.2 containing this change is available at https://epr.elastic.co/search?package=haproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues documentation Improvements or additions to documentation Integration:haproxy HAProxy Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants