Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS] Update aggregator function for a few fields having metric_type counter. #6780

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jul 3, 2023

  • Bug

What does this PR do?

This PR updates the aggregator function from average to max for few counter fields of IIS visualisations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image
image
image
image

@ritalwar ritalwar requested a review from a team as a code owner July 3, 2023 09:30
@elasticmachine
Copy link

elasticmachine commented Jul 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-04T06:10:41.420+0000

  • Duration: 14 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.909
Classes 100.0% (2/2) 💚 2.909
Methods 85.714% (30/35) 👎 -6.433
Lines 93.772% (271/289) 👍 1.913
Conditionals 100.0% (0/0) 💚

Co-authored-by: Agi K Thomas <101976829+agithomas@users.noreply.github.com>
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit afb0801 into elastic:main Jul 4, 2023
@ritalwar ritalwar changed the title [IIS] update visualisation for counter fields [IIS] Update aggregator function for a few fields having metric_type counter. Jul 4, 2023
@elasticmachine
Copy link

Package iis - 1.12.3 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants