Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Santa] Convert visualisations to Lens #6910

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

chemamartinez
Copy link
Contributor

What does this PR do?

  • Updated the visualizations of Santa dashboards to Lens
  • Fixed the Santa icon link in dashboard
  • Replaced general query with filters in visualisations
  • Updated the screenshots of the dashboard on the integration main page
  • Bumped minimum Kibana version to 8.7.1

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Integration page
Screenshot 2023-07-11 at 09 49 17

Dashboard
kibana-santa-log-overview

@chemamartinez chemamartinez marked this pull request as ready for review July 11, 2023 07:56
@chemamartinez chemamartinez requested a review from a team as a code owner July 11, 2023 07:56
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-11T07:56:41.978+0000

  • Duration: 14 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (12/12) 💚
Lines 87.963% (95/108)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez chemamartinez merged commit fee0e21 into elastic:main Jul 12, 2023
@elasticmachine
Copy link

Package santa - 3.10.0 containing this change is available at https://epr.elastic.co/search?package=santa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:santa Google Santa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants