Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ios] Fix grok to be aware of fman_fp_image #6930

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Jul 12, 2023

What does this PR do?

Fix grok to allow string fman_fp_image to be optionally included.
Added tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@LaZyDK LaZyDK requested a review from a team as a code owner July 12, 2023 07:41
@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-13T21:19:36.558+0000

  • Duration: 18 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Mar 24 12:06:47 192.168.100.2 1991218: Mar 24 12:06:47.099: %CCH323-6-CALL_PRESERVED: cch323_h225_handle_conn_loss: H.323 call preserved due to socket closure or error, Call Id = 6527, fd = 19
Jul 11 09:34:00 my-router-hostname 1663312: Jul 11 09:34:00.020: %FMANFP-6-IPACCESSLOGP: R0/0: fman_fp_image: list internet_in_gig0 denied tcp 172.16.0.26(59144) -> 10.100.8.34(1103), 1 packet
Copy link
Contributor

@efd6
Copy link
Contributor

efd6 commented Jul 13, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Jul 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (15/15) 💚
Lines 90.828% (307/338)
Conditionals 100.0% (0/0) 💚

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Jul 13, 2023

Added more tests from logs found online. Took into account that spaces might be more than one, and that fman_fp_image is not the only possible string.

@efd6
Copy link
Contributor

efd6 commented Jul 13, 2023

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 01097b5 into elastic:main Jul 13, 2023
@LaZyDK LaZyDK deleted the fix-cisco-ios-grok branch July 14, 2023 06:38
@elasticmachine
Copy link

Package cisco_ios - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants