Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mappings of flattened fields in azure billing and application insights packages #6975

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 17, 2023

What does this PR do?

Fix mappings of flattened fields in azure billing and application insights packages.

Previous code generates this unexpected mapping:

                "tags": {
                  "properties": {
                    "*": {
                      "type": "flattened"
                    }
                  }
                }

With this change, this mapping is generated:

                "tags": {
                  "type": "flattened"
                }

We also take the opportunity to increase the format spec version and fix duplicated field definitions.

These issues were identified in elastic/package-spec#527 (comment).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@jsoriano jsoriano requested a review from a team July 17, 2023 10:37
@jsoriano jsoriano self-assigned this Jul 17, 2023
@jsoriano jsoriano requested a review from a team as a code owner July 17, 2023 10:37
@mrodm
Copy link
Contributor

mrodm commented Jul 17, 2023

/test

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano
Copy link
Member Author

/test

1 similar comment
@jsoriano
Copy link
Member Author

/test

@jsoriano jsoriano added the Integration:azure Azure Logs label Jul 18, 2023
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-24T22:43:41.218+0000

  • Duration: 15 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (6/9)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano merged commit f6f56bd into elastic:main Jul 24, 2023
@jsoriano jsoriano deleted the fix-flattened-azure branch July 24, 2023 23:01
@elasticmachine
Copy link

Package azure_application_insights - 1.0.6 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights

@elasticmachine
Copy link

Package azure_billing - 1.1.3 containing this change is available at https://epr.elastic.co/search?package=azure_billing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_application_insights Azure Application Insights Metrics Overview Integration:azure_billing Azure Billing Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants