-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Istio] Update "Pilot xds expired" visualization #7007
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@@ -2739,7 +2794,7 @@ | |||
"version": 1 | |||
}, | |||
"coreMigrationVersion": "8.6.0", | |||
"created_at": "2023-03-06T17:59:55.323Z", | |||
"created_at": "2023-07-19T07:09:48.691Z", | |||
"id": "istio-f0f863b0-5941-11ed-bfb8-bbfe5b338339", | |||
"migrationVersion": { | |||
"dashboard": "8.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@constanca-m do we need to raise this to 8.8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a warning message on #tsdb-observability channel that says this "It is an issue if an dashboard is exported using elastic-package in 8.8+ and the unsupported dashboard always results in a CI failure". That is why I migrated in 8.6.0 version (it was also the previous version being used) instead of 8.8.0 @gizas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks have seen the relevant thread!
🌐 Coverage report
|
Package istio - 0.3.2 containing this change is available at https://epr.elastic.co/search?package=istio |
What does this PR do?
Update "Pilot xds expired" visualization to use last value instead of average.
"Pilot xds expired" visualization uses a counter metric,
istio.istiod.metrics.pilot_xds_expired_nonce.counter
. Currently, that metric is being used with an unsupported aggregation,average
. Since we want to migrate this integration to TSDB we have to fix that. The solution is to uselast_value
and break the visualization by the label (see screenshot section).Checklist
changelog.yml
file.Related issues
Relates to #6567.
Screenshots
Currently the visualization looks like this:
With the change in this PR, it will look like this: