Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Istio] Update "Pilot xds expired" visualization #7007

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Update "Pilot xds expired" visualization to use last value instead of average.

"Pilot xds expired" visualization uses a counter metric, istio.istiod.metrics.pilot_xds_expired_nonce.counter. Currently, that metric is being used with an unsupported aggregation, average. Since we want to migrate this integration to TSDB we have to fix that. The solution is to use last_value and break the visualization by the label (see screenshot section).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6567.

Screenshots

Currently the visualization looks like this:

image

With the change in this PR, it will look like this:

image

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner July 19, 2023 07:34
@constanca-m constanca-m self-assigned this Jul 19, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Jul 18, 2023
4 tasks
@@ -2739,7 +2794,7 @@
"version": 1
},
"coreMigrationVersion": "8.6.0",
"created_at": "2023-03-06T17:59:55.323Z",
"created_at": "2023-07-19T07:09:48.691Z",
"id": "istio-f0f863b0-5941-11ed-bfb8-bbfe5b338339",
"migrationVersion": {
"dashboard": "8.6.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@constanca-m do we need to raise this to 8.8.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning message on #tsdb-observability channel that says this "It is an issue if an dashboard is exported using elastic-package in 8.8+ and the unsupported dashboard always results in a CI failure". That is why I migrated in 8.6.0 version (it was also the previous version being used) instead of 8.8.0 @gizas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks have seen the relevant thread!

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T07:35:36.198+0000

  • Duration: 17 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 90.0% (27/30) 👎 -10.0
Lines 97.472% (347/356) 👎 -2.528
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit b65309d into elastic:main Jul 19, 2023
@constanca-m constanca-m deleted the istio-fix-dashboard branch July 19, 2023 09:47
@elasticmachine
Copy link

Package istio - 0.3.2 containing this change is available at https://epr.elastic.co/search?package=istio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants