Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netflow] Converting all visualizations to Lens #7011

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jul 19, 2023

What does this PR do?

This PR bumps the format_version, adds a small fix for observer.ip not being an array, and converting all the dashboard visualizations to lens.

While I focused on trying to keep the same format/layout in this PR, and rather have a follow-up PR to add/create new dashboards to better fit our updated views on how dashboards should look and what they should include, it was not possible to totally keep the same one, as there was too many issues with some of them.

I have added screenshots for most dashboards though not all, and added screenshots to the integration itself.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

netflow-overview
netflow-topn
traffic-analysis
netflow-conversation
netflow-geo

@P1llus P1llus requested a review from a team as a code owner July 19, 2023 10:29
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T13:25:18.737+0000

  • Duration: 14 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (9/9) 💚 75.0
Lines 92.0% (92/100) 👎 -8.0
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit 1db8687 into elastic:main Jul 19, 2023
@elasticmachine
Copy link

Package netflow - 2.10.0 containing this change is available at https://epr.elastic.co/search?package=netflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:netflow NetFlow Records
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants