Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud_security_posture] Ensure event.kind is correctly set for pipeline errors #7048

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jul 20, 2023

What does this PR do?

Modify cloud_security_posture integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner July 20, 2023 16:06
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T22:28:49.277+0000

  • Duration: 15 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

packages/cloud_security_posture/manifest.yml Outdated Show resolved Hide resolved
packages/cloud_security_posture/changelog.yml Outdated Show resolved Hide resolved
MakoWish and others added 2 commits July 24, 2023 09:44
Co-authored-by: Oren Zohar <85433724+oren-zohar@users.noreply.github.com>
Co-authored-by: Oren Zohar <85433724+oren-zohar@users.noreply.github.com>
@MakoWish
Copy link
Contributor Author

@oren-zohar, can you /test again? I don't have permissions to.

@oren-zohar
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@oren-zohar oren-zohar merged commit 99b4861 into elastic:main Aug 11, 2023
1 check passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview31 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cloud_security_posture Security Posture Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants