Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HA Proxy] Add metric_type mapping to info datastream #7164

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Jul 27, 2023

Type of Change

  • Enhancement

What does this PR do?

Add metric_type mapping to info datastream of HA Proxy

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Related issues

Screenshots

image

@agithomas
Copy link
Contributor Author

image

@agithomas agithomas requested a review from ritalwar July 27, 2023 11:19
@agithomas agithomas marked this pull request as ready for review July 27, 2023 11:20
@agithomas agithomas requested a review from a team as a code owner July 27, 2023 11:20
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-27T11:30:22.714+0000

  • Duration: 14 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas agithomas mentioned this pull request Jul 27, 2023
20 tasks
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.571
Classes 100.0% (1/1) 💚 3.571
Methods 90.476% (19/21) 👍 3.192
Lines 97.297% (180/185) 👍 4.474
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 072489b into elastic:main Jul 28, 2023
1 check passed
@elasticmachine
Copy link

Package haproxy - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=haproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants