Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Profiling: Add TLS input configuration for symbolizer #7241

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

florianl
Copy link
Member

@florianl florianl commented Aug 3, 2023

What does this PR do?

Add TLS input configuration for symbolizer.

@florianl florianl added the enhancement New feature or request label Aug 3, 2023
@florianl florianl requested a review from a team as a code owner August 3, 2023 12:01
Signed-off-by: Florian Lehner <flehner@optimyze.cloud>
@elasticmachine
Copy link

elasticmachine commented Aug 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-03T13:24:16.867+0000

  • Duration: 13 min 14 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@inge4pres inge4pres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏼
There's probably a wrong entry in the top level config, and I left a question.

categories: ["elastic_stack", "monitoring"]
description: Fleet-wide, whole-system, continuous profiling with zero instrumentation.
conditions:
kibana.version: ^8.8.0
kibana.version: ^8.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this constraint work? is it going to prevent 8.8 deployments to install the policy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - this prevents 8.8 deployments to use this integration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhmhm is this what we want? IIRC Fleet will always try to use the latest version, so that would disallow 8.8 new deployments to work?
Or since the package is bundled in the 8.8 release within Kibana it takes precedence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this what we want?

yes. Our stack works best on 8.9 onwards.

Fleet will always try to use the latest version, so that would disallow 8.8 new deployments to work?

yes - new 8.8 deployments will not get this new change.

since the package is bundled in the 8.8 release within Kibana it takes precedence?

This new package does not have an effect on old 8.8 releases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer Kibana versions will bundle this package only after this PR and elastic/kibana#163073 got merged.

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
@florianl florianl requested a review from inge4pres August 3, 2023 14:23
Copy link
Contributor

@inge4pres inge4pres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@florianl florianl merged commit 63a3b0c into main Aug 3, 2023
1 check passed
@elasticmachine
Copy link

Package profiler_symbolizer - 8.9.0-preview containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer

@andrewkroh andrewkroh added the Integration:universal_profiling_symbolizer Universal Profiling Symbolizer label Jul 22, 2024
@florianl florianl deleted the flo-up-symbolizer-TLS branch August 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:universal_profiling_symbolizer Universal Profiling Symbolizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants