-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal Profiling: Add TLS input configuration for symbolizer #7241
Conversation
Signed-off-by: Florian Lehner <flehner@optimyze.cloud>
403ee54
to
8b5d8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏🏼
There's probably a wrong entry in the top level config, and I left a question.
packages/universal_profiling_symbolizer/agent/input/input.yml.hbs
Outdated
Show resolved
Hide resolved
categories: ["elastic_stack", "monitoring"] | ||
description: Fleet-wide, whole-system, continuous profiling with zero instrumentation. | ||
conditions: | ||
kibana.version: ^8.8.0 | ||
kibana.version: ^8.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this constraint work? is it going to prevent 8.8 deployments to install the policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - this prevents 8.8 deployments to use this integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhmhm is this what we want? IIRC Fleet will always try to use the latest version, so that would disallow 8.8 new deployments to work?
Or since the package is bundled in the 8.8 release within Kibana it takes precedence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this what we want?
yes. Our stack works best on 8.9 onwards.
Fleet will always try to use the latest version, so that would disallow 8.8 new deployments to work?
yes - new 8.8 deployments will not get this new change.
since the package is bundled in the 8.8 release within Kibana it takes precedence?
This new package does not have an effect on old 8.8 releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newer Kibana versions will bundle this package only after this PR and elastic/kibana#163073 got merged.
Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Package profiler_symbolizer - 8.9.0-preview containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer |
What does this PR do?
Add TLS input configuration for symbolizer.