Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS] Add condition support to logs and metrics #7373

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

BenB196
Copy link
Contributor

@BenB196 BenB196 commented Aug 13, 2023

What does this PR do?

Enhancement - Adds support for setting condition to both log file collection and metrics. This allows for defining this integration in a policy, but only having it run on during specific conditions.

Note: Log files share a top-level condition value, and metrics share a top-level condition.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Install new version, confirm that condition fields are available and can be set.

Related issues

Screenshots

image

image

@BenB196 BenB196 requested a review from a team as a code owner August 13, 2023 23:58
@elasticmachine
Copy link

elasticmachine commented Aug 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T04:56:24.815+0000

  • Duration: 14 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.362
Classes 100.0% (2/2) 💚 3.362
Methods 85.714% (30/35) 👎 -6.703
Lines 94.562% (313/331) 👍 6.292
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 merged commit 9a3b520 into elastic:main Sep 4, 2023
1 check passed
@BenB196 BenB196 deleted the iis-condition-support branch November 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants