Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Azure Metrics] Migrate Database Account Overview dashboard to lens #7428

Conversation

rajvi-patel-22
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Database Account visualizations to the lens in the current Kibana version 8.4.0 itself.

  • Statistics for Database Account Lens migration:

Migration stats

  Before Migration     After Migration    
  Visualization Lens Old Input controls Visualization Lens New control panels
[Azure Metrics] Database Account Overview 6 0 1 0 6 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Note

@rajvi-patel-22 rajvi-patel-22 self-assigned this Aug 17, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T06:40:48.190+0000

  • Duration: 14 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👎 -1.667
Lines 100.0% (21/21) 💚
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review August 17, 2023 07:33
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner August 17, 2023 07:33
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rajvi-patel-22 rajvi-patel-22 requested review from kush-elastic and a team August 17, 2023 08:47
@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_metrics Azure Resource Metrics labels Aug 21, 2023
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 4a27cc1 into elastic:main Aug 28, 2023
1 check passed
@elasticmachine
Copy link

Package azure_metrics - 1.0.25 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Azure Metrics] Database Account Lens Migration
4 participants