-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up the stack to 7.13 #745
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
It looks like I discovered more fields in 7.13.0-SNAPSHOT for the Kubernetes integration: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-745/1/tests |
84ac4db
to
107f797
Compare
@@ -12,6 +12,15 @@ | |||
type: boolean | |||
description: | | |||
Node unschedulable status | |||
- name: disk_pressure | |||
type: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this I found we have an issue with the mapping. Opened a PR to fix it: elastic/beats#24241. Would you mind to adjust this one accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't do it right now due to type check (expecting boolean). We can do it later, unfortunately, once master starts failing. Keep in mind that we'll have to wait for the Beats and Agent's image to be built first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this issue privately, seems that it should be keyword (values: true, false, unknown). I will try to adjust the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only one nit. Thanks!
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* bump-up-stack-7.13 * Fix: add missing Kubernetes metrics * Update version * Fix: use keyword * Update packages/kubernetes/data_stream/state_node/fields/fields.yml Co-authored-by: Chris Mark <chrismarkou92@gmail.com> * Update packages/kubernetes/data_stream/state_node/fields/fields.yml Co-authored-by: Chris Mark <chrismarkou92@gmail.com> * Update packages/kubernetes/data_stream/state_node/fields/fields.yml Co-authored-by: Chris Mark <chrismarkou92@gmail.com> * Fix: elastic-package build * Add kubernetes.node.status.out_of_disk Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
What does this PR do?
This PR updates the dependency on elastic-package to use the 7.13.0-SNAPSHOT stack.
Checklist
- [ ] I have reviewed [tips for building integrations](https://github.com/elastic/integrations/blob/master/docs/tips_for_building_integrations.md) and this pull request is aligned with them.- [ ] I have verified that all data streams collect metrics or logs.- [ ] I have added an entry to my package'schangelog.yml
file.How to test this PR locally
CI will verify it.