Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][WebSphere Application Server] Add compatibility and update title in manifest #7505

Merged
merged 4 commits into from
Sep 4, 2023
Merged

[O11y][WebSphere Application Server] Add compatibility and update title in manifest #7505

merged 4 commits into from
Sep 4, 2023

Conversation

ali786XI
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Updated the metrics toggle title in manifest
  • Added compatibility section in README

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@ali786XI ali786XI added enhancement New feature or request Integration:websphere_application_server WebSphere Application Server labels Aug 23, 2023
@ali786XI ali786XI self-assigned this Aug 23, 2023
@ali786XI ali786XI requested a review from a team as a code owner August 23, 2023 12:40
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T09:13:31.822+0000

  • Duration: 27 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚 12.174
Lines 100.0% (488/488) 💚 4.0
Conditionals 100.0% (0/0) 💚

@ali786XI ali786XI requested review from harnish-elastic and harnish-crest and removed request for harnish-crest August 24, 2023 12:42
muthu-mps
muthu-mps approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ali786XI ali786XI merged commit d94b67e into elastic:main Sep 4, 2023
1 check passed
@elasticmachine
Copy link

Package websphere_application_server - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@harnish-crest harnish-crest harnish-crest approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@ali786XI ali786XI

Labels
enhancement New feature or request Integration:websphere_application_server WebSphere Application Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][WebSphere Application Server] Add compatibility and update title in manifest
5 participants
@ali786XI @elasticmachine @muthu-mps @harnish-crest @harnish-elastic