[integrations][okta] - Added support for Oauth2 for okta.system data stream

[ShourieG]

Type of change

• Enhancement

What does this PR do?

This PR adds OAuth2 support for Okta System Logs data stream in the Okta integration.

Note

This PR can only be merged after the public release of 8.10 because of internal dependencies and features only available in 8.10. System tests will fail until 8.10 changes are available in the CI pipeline.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Closes [Meta][Okta] Support OAuth 2.0 for Integration #6974

Screenshots

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-09-12T07:14:42.977+0000

• Duration: 17 min 56 sec

Test stats 🧪

Test	Results
Failed	0
Passed	8
Skipped	0
Total	8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (1/1)	💚
Files	100.0% (1/1)	💚
Classes	100.0% (1/1)	💚
Methods	100.0% (19/19)	💚 66.667
Lines	92.026% (577/627)	👎 -7.974
Conditionals	100.0% (0/0)	💚

[bhapas]

LGTM.

Is there a way to document the common pitfalls regarding the config of OAuth2 on Okta server.
Lately, there were few issues with other products that customers faced regarding misconfiguration of the OAuth servers and leading to integration issues.

[ShourieG]

LGTM.

Is there a way to document the common pitfalls regarding the config of OAuth2 on Okta server. Lately, there were few issues with other products that customers faced regarding misconfiguration of the OAuth servers and leading to integration issues.

@bhapas The main issue I see is different oauth2 implementations require specific steps from users to get things working, specially in the case of machine to machine communication. The implementation of oauth2 followed by okta here deviates from standard oauth2 conventions making a single document covering pitfalls of oauth2 as a whole somewhat difficult. It needs to be a case by case basis in my opinion.

[bhapas]

LGTM.
Is there a way to document the common pitfalls regarding the config of OAuth2 on Okta server. Lately, there were few issues with other products that customers faced regarding misconfiguration of the OAuth servers and leading to integration issues.

@bhapas The main issue I see is different oauth2 implementations require specific steps from users to get things working, specially in the case of machine to machine communication. The implementation of oauth2 followed by okta here deviates from standard oauth2 conventions making a single document covering pitfalls of oauth2 as a whole somewhat difficult. It needs to be a case by case basis in my opinion.

@ShourieG Yeah. I meant the OAuth2 configuration for Okta servers , not in general.

[ShourieG]

LGTM.
Is there a way to document the common pitfalls regarding the config of OAuth2 on Okta server. Lately, there were few issues with other products that customers faced regarding misconfiguration of the OAuth servers and leading to integration issues.

@bhapas The main issue I see is different oauth2 implementations require specific steps from users to get things working, specially in the case of machine to machine communication. The implementation of oauth2 followed by okta here deviates from standard oauth2 conventions making a single document covering pitfalls of oauth2 as a whole somewhat difficult. It needs to be a case by case basis in my opinion.

@ShourieG Yeah. I meant the OAuth2 configuration for Okta servers , not in general.

@bhapas Yea we will take up this discussion point in the team meet and figure out a better way for these documentations.

[bhapas]

LGTM.

Can you add some screenshots for the changed UI

[elasticmachine]

Package okta - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=okta