Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring GCP credentials -Fix continuation #7546

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Aug 25, 2023

On my previous PR (#7537) I forgot to include the changelog and manifest yml change
as such It didnt trigger the build to see my changes

@animehart animehart requested a review from a team as a code owner August 25, 2023 21:37
Copy link
Contributor

@mitodrummer mitodrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

elasticmachine commented Aug 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-25T21:46:25.699+0000

  • Duration: 16 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@animehart animehart merged commit 08b81d3 into elastic:main Aug 25, 2023
1 check passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.2-preview2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@oren-zohar
Copy link
Contributor

@animehart was it tested with preview? Can we publish it in production?

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cloud_security_posture Security Posture Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants