Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Istio] Revert Istio metric type to object #7607

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Aug 30, 2023

What does this PR do?

Reverts the metric type to object again. The type for the metric as it is now was introduced in #6889.

This is related to the work mentioned in elastic/kibana#155004.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Aug 30, 2023
@constanca-m constanca-m requested a review from a team as a code owner August 30, 2023 06:40
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-30T06:41:33.110+0000

  • Duration: 16 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.362
Classes 100.0% (3/3) 💚 3.362
Methods 90.0% (27/30) 👎 -1.828
Lines 97.472% (347/356) 👍 9.163
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit e4be335 into elastic:main Aug 30, 2023
1 check passed
@constanca-m constanca-m deleted the isto-revert-metric-format branch August 30, 2023 09:02
@elasticmachine
Copy link

Package istio - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=istio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants